Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed image ratio while cropping and required explicitly defined Papercrop as a processor #50

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

davidmccoy
Copy link

@davidmccoy davidmccoy commented Jun 30, 2016

Papercrop is not properly translating Jcrop's cropping information for images that are smaller than the preview image. I applied a previously-submitted JavaScript update to fix this bug.

I also removed the functionality that automatically adds Papercrop to the end of the processor chain. I believe this is a worthwhile improvement for a few reasons:

  1. There have also been multiple requests to have Papercrop only process a single style.
  2. It is a bit heavy-handed to apply Papercrop to EVERY style without any way of removing it from the processor chain.
  3. It also seems unintuitive to have Papercrop automatically added to the end of the processor chain because it hides the Papercrop processor behind "Rails magic."

Thanks for your time!

@rsantamaria
Copy link
Owner

@davidmccoy Sadly I can't find a way to reproduce the proportions bug without the use of css tricks.
bug-proportions-1
This is a 250x250 image in a preview of 500 pixels wide, without the fix.
Please, could you give me a real example of the bug using one of the test apps?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants